From 2cc68aead6bec811d20a7a880a28b80813532e8d Mon Sep 17 00:00:00 2001 From: Erik Date: Fri, 13 Mar 2015 09:51:53 -0400 Subject: [PATCH] Don't poll on sendPollMessage --- SwiftIO/SocketEngine.swift | 15 +++++---------- SwiftIO/SocketParser.swift | 2 ++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/SwiftIO/SocketEngine.swift b/SwiftIO/SocketEngine.swift index ded5f53..326cc2c 100644 --- a/SwiftIO/SocketEngine.swift +++ b/SwiftIO/SocketEngine.swift @@ -286,7 +286,6 @@ public class SocketEngine: NSObject, WebSocketDelegate { } let (urlPolling, urlWebSocket) = self.createURLs(params: opts) - self.urlPolling = urlPolling self.urlWebSocket = urlWebSocket let reqPolling = NSURLRequest(URL: NSURL(string: urlPolling + "&b64=1")!) @@ -472,7 +471,7 @@ public class SocketEngine: NSObject, WebSocketDelegate { self?.sendWebSocketMessage(msg, withType: PacketType.MESSAGE, datas: datas) } else { // println("sending poll: \(msg):\(datas)") - self?.sendPollMessage(msg, withType: PacketType.MESSAGE, datas: datas, doPoll: true) + self?.sendPollMessage(msg, withType: PacketType.MESSAGE, datas: datas) } } } @@ -494,12 +493,12 @@ public class SocketEngine: NSObject, WebSocketDelegate { if self.websocket { self.sendWebSocketMessage("", withType: PacketType.PING) } else { - self.sendPollMessage("", withType: PacketType.PING, doPoll: false) + self.sendPollMessage("", withType: PacketType.PING) } } private func sendPollMessage(msg:String, withType type:PacketType, - datas:[NSData]? = nil, doPoll poll:Bool) { + datas:[NSData]? = nil) { // println("Sending poll: \(msg) as type: \(type.rawValue)") let strMsg = "\(type.rawValue)\(msg)" @@ -513,11 +512,7 @@ public class SocketEngine: NSObject, WebSocketDelegate { } } - if !self.waitingForPoll && self.waitingForPost && poll { - self.doPoll() - } else { - self.flushWaitingForPost() - } + self.flushWaitingForPost() } private func sendWebSocketMessage(str:String, withType type:PacketType, datas:[NSData]? = nil) { @@ -552,7 +547,7 @@ public class SocketEngine: NSObject, WebSocketDelegate { // Do a fast upgrade self.fastUpgrade = true self.probing = false - self.sendPollMessage("", withType: PacketType.NOOP, doPoll: false) + self.sendPollMessage("", withType: PacketType.NOOP) } } diff --git a/SwiftIO/SocketParser.swift b/SwiftIO/SocketParser.swift index cc685f6..5cefc66 100644 --- a/SwiftIO/SocketParser.swift +++ b/SwiftIO/SocketParser.swift @@ -257,6 +257,7 @@ class SocketParser { socket.handleEvent(event, data: parsed, isInternalMessage: false, wantsAck: ackNum.toInt(), withAckType: 3) } + return } else if let strData = data { // There are multiple items in the message @@ -271,6 +272,7 @@ class SocketParser { socket.handleEvent(event, data: parsed, isInternalMessage: false, wantsAck: ackNum.toInt(), withAckType: 3) } + return } }